fix(review): show LGTM when review finds no issues#15
Open
abhay-factory wants to merge 1 commit intomasterfrom
Open
fix(review): show LGTM when review finds no issues#15abhay-factory wants to merge 1 commit intomasterfrom
abhay-factory wants to merge 1 commit intomasterfrom
Conversation
Add instruction to the review skill output section so the agent responds with a concise LGTM message instead of a generic reply when the review produces no findings. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
|
||
| When invoked locally (TUI/CLI), analyze the changes and provide a structured summary of findings. List each finding with its priority, file, line, and description. | ||
|
|
||
| If the review produces **no findings**, respond with a short **LGTM** message (e.g., "LGTM — no issues found."). Do not pad it with caveats or disclaimers. |
Contributor
There was a problem hiding this comment.
Generally a good change, but do we want to update the original comment about the droid working, or post a new comment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an instruction to the review skill's Output section so the agent responds with a concise LGTM message instead of a generic reply when the code review produces no findings.
How Has This Been Tested?
Reviewed the SKILL.md diff to verify correctness.